Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added device WISI Tangram #10039

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
4 participants
@djamp42
Copy link
Contributor

commented Mar 27, 2019

This is IP/QAM multiplexer.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

mib_dir:
- wisi
over:
- { graph: '', text: '' }

This comment has been minimized.

Copy link
@TheGreatDoc

TheGreatDoc Mar 27, 2019

Contributor

Did you forgot to remove or replace this?

This comment has been minimized.

Copy link
@djamp42

djamp42 Mar 27, 2019

Author Contributor

@TheGreatDoc I dont know what to put in there. I guess it could be fan sensors? This thing is horrible for snmp support..basically none of the interfaces show up besides the managment, no CPU, etc.. I got all I could out of it

This comment has been minimized.

Copy link
@murrant

murrant Mar 27, 2019

Member

just make it an empty array over: [] ?

This comment has been minimized.

Copy link
@TheGreatDoc

TheGreatDoc Mar 27, 2019

Contributor

Cant he just delete the over section?

This comment has been minimized.

Copy link
@djamp42

djamp42 Mar 27, 2019

Author Contributor

@TheGreatDoc I tried deleting it and it threw some errors on discovery . I noticed another OS with that same style so i just copied that.. Making it a empty array works fine.. I'll change it.

@murrant murrant added the Device 🖥 label Mar 27, 2019

@PipoCanaja PipoCanaja added this to the 1.51 milestone Mar 28, 2019

@PipoCanaja PipoCanaja changed the title Device WISI Tangram Added device WISI Tangram Apr 2, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

LGTM. @TheGreatDoc ?

@TheGreatDoc TheGreatDoc merged commit c1fab98 into librenms:master Apr 3, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.