Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path in Smokeping conf file #10045

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
5 participants
@fjwcash
Copy link
Contributor

commented Mar 28, 2019

Wrong path is given for including the librenms.conf file into the SmokePing config.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Update Smokeping.md
Wrong path is given for including the librenms.conf file into the SmokePing config.
@sorano

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Nice find!

@TheGreatDoc
Copy link
Contributor

left a comment

LGTM

@TheGreatDoc TheGreatDoc changed the title Update Smokeping.md Fix path in Smokeping conf file Mar 31, 2019

@TheGreatDoc TheGreatDoc merged commit a4513e9 into librenms:master Mar 31, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf changed the title Fix path in Smokeping conf file Fixed path in Smokeping conf file Mar 31, 2019

mattie47 added a commit to mattie47/librenms that referenced this pull request Apr 3, 2019

Update Smokeping.md
Fixed a couple more things after librenms#9731 and librenms#10045 make some changes.

@mattie47 mattie47 referenced this pull request Apr 3, 2019

Merged

Update Smokeping.md #10064

1 of 1 task complete
@mattie47

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

FYI @fjwcash @fake-name I've made a couple more minor changes to the doc...

PipoCanaja added a commit that referenced this pull request Apr 3, 2019

Updated Smokeping.md (#10064)
Fixed a couple more things after #9731 and #10045 make some changes.

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Updated Smokeping.md (librenms#10064)
Fixed a couple more things after librenms#9731 and librenms#10045 make some changes.

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Updated Smokeping.md (librenms#10064)
Fixed a couple more things after librenms#9731 and librenms#10045 make some changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.