Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RegEx string for correct definitions for Proxmox 4.x nodes #10048

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@n0taz
Copy link
Contributor

commented Mar 29, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented Mar 29, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Alexander Tsyganov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@n0taz

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2019

Ohh, licence/cla still pending... Close it.

@n0taz n0taz closed this Mar 31, 2019

@laf

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

We don't need it for something so simple.

@laf laf reopened this Mar 31, 2019

@laf laf added the Device 🖥 label Mar 31, 2019

@laf laf merged commit 943dbe4 into librenms:master Apr 9, 2019

5 of 6 checks passed

license/cla Contributor License Agreement is not signed yet.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.