Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended card support for adva_fsp150 family #10049

Merged
merged 7 commits into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Mar 30, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja self-assigned this Mar 30, 2019

@PipoCanaja PipoCanaja added this to the 1.51 milestone Mar 30, 2019

@PipoCanaja PipoCanaja changed the title Extended card support for adva_fsp150 ge112 WIP - Extended card support for adva_fsp150 ge112 Mar 30, 2019

@PipoCanaja PipoCanaja force-pushed the PipoCanaja:adva branch from 8f4a816 to 761c6fe Apr 2, 2019

@PipoCanaja PipoCanaja changed the title WIP - Extended card support for adva_fsp150 ge112 Extended card support for adva_fsp150 family Apr 2, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

From my side, this is ready for review.

@laf

laf approved these changes Apr 9, 2019

Copy link
Member

left a comment

LGTM.

@laf laf merged commit 780ee36 into librenms:master Apr 9, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 2 fixed issues
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:adva branch Apr 29, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Updated support for adva_fsp150 devices (librenms#10049)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.