Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PPPoE Sessions Graph for Mikrotik #10056

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@neszt
Copy link
Contributor

commented Apr 1, 2019

Added PPPoE Sessions Graph for Mikrotik. Cli command to get session count: /interface pppoe-server print count-only

Coding style and implement idea from 9f553af.

Tested on Mikrotik Firmware version 6.23-6.44, but should work with all firmware versions.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

newdevice: Added PPPoE Sessions Graph for Mikrotik
Cli command to get session count: /interface pppoe-server print count-only
@CLAassistant

This comment has been minimized.

Copy link

commented Apr 1, 2019

CLA assistant check
All committers have signed the CLA.

@PipoCanaja PipoCanaja changed the title newdevice: Added PPPoE Sessions Graph for Mikrotik Added PPPoE Sessions Graph for Mikrotik Apr 1, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

Hi @neszt
Thanx for your contribution. I tested this and it works as expected on the device I have here (CHR, 6.42.1).

The only thing you might be interested in is to store the value in the DB, for alerting purposes, cause you cannot alert on values that are only graphed with RRD files.
You could re-implement this in YAML in includes/definitions/discovery/routeros.yaml and use the type "count", and you would then get the value stored in the DB.

If you don't need any alerting, your implementation is perfectly fine.

@neszt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Hello, @PipoCanaja,

Thank you for your quick answer. I'm glad to hear you tested it and works as expected.

I don't need any alerting.

Regards,

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

So it looks good to me ! Let's merge it.

@PipoCanaja PipoCanaja merged commit f30d5af into librenms:master Apr 2, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.