Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification creation #10058

Merged
merged 3 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Apr 2, 2019

also refactor so it is a bit more logical

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix notification creation
also refactor so it is a bit more logical

@murrant murrant added the Bug 🐞 label Apr 2, 2019

@laf
Copy link
Member

left a comment

This allows blank notifications to be created so probably just needs a check that the values we expect have been passed (I realise it never did this check before).

@laf laf added the WebUI label Apr 2, 2019

@laf laf added this to the 1.51 milestone Apr 2, 2019

@murrant murrant requested a review from laf Apr 2, 2019

@laf

laf approved these changes Apr 3, 2019

@laf

laf approved these changes Apr 3, 2019

Copy link
Member

left a comment

LGTM

@murrant murrant merged commit 68916a1 into librenms:master Apr 4, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:create-notif-fix branch Apr 4, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix notification creation (librenms#10058)
* Fix notification creation
also refactor so it is a bit more logical

* Don't allow empty title and body

* Updated to use error message in toastr

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Fix notification creation (librenms#10058)
* Fix notification creation
also refactor so it is a bit more logical

* Don't allow empty title and body

* Updated to use error message in toastr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.