Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial support for teltonika #10059

Merged
merged 5 commits into from Apr 8, 2019

Conversation

Projects
None yet
4 participants
@tomarch
Copy link
Contributor

commented Apr 2, 2019

Hi,

First PR for support TELTONIKA products.
Works for RUT95X which is LTE router.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

tomarch added some commits Apr 2, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

Hi @tomarch
Thanx for your contribution.
Could you please rename the mib files to match the MIB official name ?

@tomarch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

This is the name given by Teltonika.
Both file refer to "TELTONIKA-MIB".
Which name can i set ?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

Only 1 file can have a name so yes, you need to remove the not necessary one (it won't be used by snmpwalk anyway).
And for devices using the 2nd one, you have to create a 2nd OS and a 2nd mib directory.

@tomarch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Ok, thanks.

@PipoCanaja PipoCanaja changed the title initial support for teltonika Added initial support for teltonika Apr 2, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

Bonjour !
Looks good. Here is the test data. Let's run the tests this and if all good, will be ready to merge.
++

@tomarch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

seems to be all good.
Thx

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

rutos.json is not good.

Please rerun ./script/save-test-data.php -o rutos and commit the resulting file.

(You can check the results of the Travis tests)

@tomarch tomarch force-pushed the tomarch:teltonika branch from 4aa5864 to 2173a9f Apr 5, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

Bonjour,
It seems that, for some reason, when you run tests, it does not match the correct OS on the data. Are you running the test in the correct branch of your dev server?
Basically, you have to fix the json file and check on TravisCI result, which has to pass.
++

@spencerbutler

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

@tomarch This can be a tricky one to figure out. I typically run my tests like this to avoid the "data doesn't match!" issue. Most of the time, it is cache/os_defs.cache ruining your game. Good luck, and hop on discord with any questions.

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

This happened because the binary png files don't come through in patches...

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit e7ba1b1 into librenms:master Apr 8, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added initial support for teltonika (librenms#10059)
* initial support for teltonika
* fix sensors
* fix mibs name
* add rutos.json
* Update rutos.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.