Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Linksys support, including POE #10075

Merged
merged 9 commits into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Apr 7, 2019

Fixes #9718

This PR adds POE graphs, even if not all the values that are polled on other OSes are available on this one.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 10075
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja added this to the 1.51 milestone Apr 7, 2019

@PipoCanaja PipoCanaja self-assigned this Apr 7, 2019

@laf
Copy link
Member

left a comment

I'm unsure about including so many unused MIBs but wouldn't block based on that - they could be useful longer term

Show resolved Hide resolved includes/polling/os/linksys-ss.inc.php Outdated

@laf laf added the User-Pending label Apr 9, 2019

@PipoCanaja PipoCanaja force-pushed the PipoCanaja:linksys branch from 34a38f7 to d093c54 Apr 9, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

About the mib, yes, I did hesitate, but depending on device, they might be useful and help others add sensors or other things that make sense on their devices, and push it back to git ...

@PipoCanaja PipoCanaja removed the User-Pending label Apr 9, 2019

@laf

laf approved these changes Apr 9, 2019

Copy link
Member

left a comment

LGTM :)

@laf laf merged commit 36e709e into librenms:master Apr 9, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:linksys branch Apr 29, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Improved Linksys support, including POE (librenms#10075)
Fixes librenms#9718 

This PR adds POE graphs, even if not all the values that are polled on other OSes are available on this one.  

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 10075`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Improved Linksys support, including POE (librenms#10075)
Fixes librenms#9718 

This PR adds POE graphs, even if not all the values that are polled on other OSes are available on this one.  

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 10075`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.