Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detection for ESW 5xx series of Cisco SB devices #10077

Merged
merged 5 commits into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@laf
Copy link
Member

commented Apr 9, 2019

Fixes: #9065

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@laf laf added the Device 🖥 label Apr 9, 2019

laf added some commits Apr 9, 2019

@PipoCanaja
Copy link
Contributor

left a comment

Let's go with this one if it is OK with you. I have another PR I started yesterday but did not send with some discovery details. Will send it after you merge this one @laf

@laf

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Let's go with this one if it is OK with you. I have another PR I started yesterday but did not send with some discovery details. Will send it after you merge this one @laf

Sounds good @PipoCanaja. Thanks

@PipoCanaja PipoCanaja merged commit 0a7b0d4 into librenms:master Apr 9, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-9065 branch Apr 9, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added detection for ESW 5xx series of Cisco SB devices (librenms#10077)
* Added detection for ESW 5xx series of Cisco SB devices

* Added test files

* Fixed the regex

* Updated definitions

* Final fix hopefully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.