Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to display minimum values in uptime graphs. #10078

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@Slushnas
Copy link
Contributor

commented Apr 9, 2019

Fixes an issue with several uptime graphs using the average value when it should be using the minimum value.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented Apr 9, 2019

CLA assistant check
All committers have signed the CLA.

@laf

laf approved these changes Apr 11, 2019

Copy link
Member

left a comment

Well spotted :)

@laf laf merged commit b81af32 into librenms:master Apr 11, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fixed display minimum values in uptime graphs. (librenms#10078)
Fixes an issue with several uptime graphs using the average value when it should be using the minimum value.

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Fixed display minimum values in uptime graphs. (librenms#10078)
Fixes an issue with several uptime graphs using the average value when it should be using the minimum value.

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.