Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easily setting font colors for RRD graphs is now possible #10083

Merged
merged 3 commits into from Apr 28, 2019

Conversation

Projects
None yet
4 participants
@VVelox
Copy link
Contributor

commented Apr 10, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Now make all your font colors green for graph text.

$config['rrdgraph_def_text_color'] = '00FF00';

Or really any other color. This is handy for those of us who use light on dark schemes as the black on white is hard to read.

https://i.imgur.com/mXdxmC6.png <--- 00FF00 example graph

@kkrumm1

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Are you going to post the code for the your dark theme? 😀

@VVelox

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

@kkrumm1 I use Dark Background and Light Text addon with firefox. I don't have a custom theme (Is that even possible with LibreNMS?).

https://addons.mozilla.org/en-US/firefox/addon/dark-background-light-text/

That said also added a note about the variable and suggested 0000FF as a color that works decent for both dark and light.

@kkrumm1

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

@kkrumm1

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Web files have been moved to includes/html, you will need to update your PR, sorry for the trouble. Let us know if you need any help.

@VVelox

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@murrant Updated from master. First time merge has ever worked nicely for me. :)

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 7609253 into librenms:master Apr 28, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Setting font colors for RRD graphs is now possible (librenms#10083)
* easily setting font colors for RRD graphs is now possible

* add a comment explaining the variable

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Setting font colors for RRD graphs is now possible (librenms#10083)
* easily setting font colors for RRD graphs is now possible

* add a comment explaining the variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.