Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arp api network query #10085

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Apr 10, 2019

It was using a non-existent function

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the API label Apr 10, 2019

Fix arp api network query
It was using a non-existent function

@murrant murrant force-pushed the murrant:api-arp-subnet-fix branch from abc92f6 to 47f6abb Apr 10, 2019

@laf

laf approved these changes Apr 10, 2019

Copy link
Member

left a comment

LGTM + Tested

@laf laf merged commit 8926d7c into librenms:master Apr 10, 2019

5 of 6 checks passed

codeclimate 3 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:api-arp-subnet-fix branch Apr 10, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fixed arp api network query (librenms#10085)
It was using a non-existent function

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.