Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get and display the image patch version on Huawei VRP devices #10099

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Apr 12, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja self-assigned this Apr 12, 2019

@PipoCanaja PipoCanaja changed the title Get the patch applied to Huawei VRP devices WIP Get the patch applied to Huawei VRP devices Apr 13, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

Tests to adapt.

@PipoCanaja PipoCanaja force-pushed the PipoCanaja:patchVersion branch from 44e6e31 to 0fa9914 Apr 13, 2019

@PipoCanaja PipoCanaja changed the title WIP Get the patch applied to Huawei VRP devices Get and display the image patch version on Huawei VRP devices Apr 13, 2019

@PipoCanaja PipoCanaja added this to the 1.51 milestone Apr 15, 2019

@jozefrebjak
Copy link
Contributor

left a comment

@PipoCanaja works like a charm, thank you 👍

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

You are welcome. The patch will be included in next stable release, and should arrive in master asap.

@murrant murrant merged commit bfa7537 into librenms:master Apr 29, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:patchVersion branch Apr 29, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Get and display the image patch version on Huawei VRP devices (libren…
…ms#10099)

* Try to find the patch applied to this device

* tests all

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Get and display the image patch version on Huawei VRP devices (libren…
…ms#10099)

* Try to find the patch applied to this device

* tests all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.