Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devices: Add discovery ObjectID for Barracuda NGFW #10102

Merged
merged 2 commits into from Apr 27, 2019

Conversation

Projects
None yet
2 participants
@pobradovic08
Copy link
Contributor

commented Apr 13, 2019

  • Updated PHION-MIB
  • Added Object ID for discovery of Barracuda NGFW
  • Added graph for active sessions under Graphs > Firewall

Tested on Barracuda F80

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@label-actions

This comment has been minimized.

Copy link

commented Apr 27, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

Hi,
Thanx for your PR. Could you also run ./scripts/save-test-data.php and add the JSON file ? This requires snmpsim to be up and running.
Thanx

@pobradovic08

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

Hi,

Thanks for the help, I ran collect-snmp-data.php and save-test-data.php following the instructions in the docs, and commited the JSON file alongside the .snmprec. Hope it's ok.

Thanks,
Pavle.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

Looks good to me ! Let's merge it.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit b8c4f38 into librenms:master Apr 27, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added session graphs for Barracuda NGFW (librenms#10102)
* devices: Corrected discovery object ID for Barracuda NGFW; Added fw session graphs
* device: Added test data

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Added session graphs for Barracuda NGFW (librenms#10102)
* devices: Corrected discovery object ID for Barracuda NGFW; Added fw session graphs
* device: Added test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.