Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netscaler vservers table update #10103

Merged
merged 2 commits into from May 20, 2019

Conversation

Projects
None yet
2 participants
@pobradovic08
Copy link
Contributor

commented Apr 13, 2019

  • Adjusted vservers table design to be more inline with general look and feel of LibreNMS
  • Added header row
  • Added vserver type column
  • Added ability to sort by vserver name, inbound traffic or outbound traffic

Before:
Before

After:
After

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@pobradovic08 pobradovic08 force-pushed the pobradovic08:citrix-ns branch from 7c5c415 to 717c515 Apr 14, 2019

@murrant murrant added the WebUI label Apr 30, 2019

@murrant murrant merged commit 1e76915 into librenms:master May 20, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Netscaler vservers table update (librenms#10103)
* webui: Netscaler Vservers add table header and vserver type

* webui: Netscaler Vserver sorting (name, traffic in/out)

@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.