Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime graph handle snmp server caching #10113

Merged
merged 3 commits into from May 1, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Apr 15, 2019

Handle server caching more gracefully than setting the throughput to 0 Mbps

image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Realtime graph handle server caching
Handle server caching more gracefully than setting the throughput to 0 Mbps

@murrant murrant added the WebUI label Apr 15, 2019

@murrant

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

Not sure if it is a problem or not, but if the port legitimately has no traffic flow across it for both in and out directions, it will not graph that.

@murrant murrant changed the title Realtime graph handle server caching Realtime graph handle snmp server caching Apr 17, 2019

@laf

laf approved these changes May 1, 2019

Copy link
Member

left a comment

Tested and works for me.

@laf laf merged commit d7bcd92 into librenms:master May 1, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:realtime-caching branch May 1, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Realtime graph handle snmp server caching (librenms#10113)
* Realtime graph handle server caching
Handle server caching more gracefully than setting the throughput to 0 Mbps

* smoother estimated interval

* don't change the graphing timescale

@lock lock bot locked as resolved and limited conversation to collaborators Jun 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.