Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Example-Hardware-Setup.md #10115

Merged
merged 3 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@TheGreatDoc
Copy link
Contributor

commented Apr 16, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja
Copy link
Contributor

left a comment

Fighting for the fix :)

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

@PipoCanaja any reason to change MariaDB to MySQL?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Not a single one :) Wrong merge of the 2 concurrent changes :)

@PipoCanaja PipoCanaja merged commit f63d7a8 into master Apr 17, 2019

7 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Update Example-Hardware-Setup.md (librenms#10115)
* Update Example-Hardware-Setup.md

* Restore DB type

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Update Example-Hardware-Setup.md (librenms#10115)
* Update Example-Hardware-Setup.md

* Restore DB type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.