Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify graph format from GET param #10118

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
3 participants
@aruhier
Copy link
Contributor

commented Apr 16, 2019

Allows to specify a graph format (svg or png) from the GET parameter "graph_type"

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Looks good, I'm not sure why you want this but no problem merging it.
Does SVG type give you problems sometimes?

Specify graph format from GET param
Allows to specify a graph format (svg or png) for the GET parameter
"graph_type"

@aruhier aruhier force-pushed the aruhier:graph_type_parameter branch from d58059d to fc847b5 Apr 24, 2019

@aruhier

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

We're using Librenms at Online.net, and we need to force getting a png in some situations. It's a special use case, thanks a lot for being ok to merge it!

@laf

laf approved these changes May 1, 2019

Copy link
Member

left a comment

Lgtm

Probably would be good to document it somewhere but I’m not sure where

@laf laf merged commit 6e76f1d into librenms:master May 1, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the WebUI label May 1, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Specify graph format from GET param (librenms#10118)
Allows to specify a graph format (svg or png) for the GET parameter
"graph_type"

@lock lock bot locked as resolved and limited conversation to collaborators Jun 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.