Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Fix error when no fdb are found #10125

Merged
merged 5 commits into from May 13, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented Apr 19, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the API label Apr 19, 2019

murrant added some commits Apr 19, 2019

@murrant murrant merged commit c097747 into librenms:master May 13, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 1 fixed issue
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-fdb-null branch May 13, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

API Fix error when no fdb are found (librenms#10125)
* Fix error when no fdb are found

* actually, it was totally broken...
fix untested

* missing device update

* cleanup

* Update api_functions.inc.php

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.