Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix call to shortDisplayName on null in MuninPluginController #10126

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
3 participants
@CirnoT
Copy link
Contributor

commented Apr 19, 2019

MuninPluginController did not ask for device_id in baseQuery, hence later it was impossible to construct valid Device model causing subsequent call to shortDisplayName in formatItem to be on NULL.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

fix call to shortDisplayName on null in MuninPluginController
MuninPluginController did not ask for device_id in baseQuery, hence later it was impossible to construct valid Device model causing subsequent call to shortDisplayName in formatItem to be on NULL.
@CLAassistant

This comment has been minimized.

Copy link

commented Apr 19, 2019

CLA assistant check
All committers have signed the CLA.

@murrant murrant merged commit 141eab1 into librenms:master Apr 19, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Nice fix

@CirnoT CirnoT deleted the CirnoT:CirnoT-patch-1 branch Apr 28, 2019

@murrant murrant added the Bug 🐞 label Apr 29, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

fix call to shortDisplayName on null in MuninPluginController (libren…
…ms#10126)

MuninPluginController did not ask for device_id in baseQuery, hence later it was impossible to construct valid Device model causing subsequent call to shortDisplayName in formatItem to be on NULL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.