Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLDP Discovery by IP #10130

Merged
merged 4 commits into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Apr 20, 2019

This PR collects the IP address from the OID in the LLDP replies, because there is no way to get them directly from the values.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja self-assigned this Apr 20, 2019

PipoCanaja added some commits Apr 20, 2019

@PipoCanaja PipoCanaja added this to the 1.51 milestone Apr 21, 2019

@murrant murrant modified the milestones: 1.51, 1.52 Apr 29, 2019

@murrant murrant merged commit 3053736 into librenms:master Apr 30, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Feature label Apr 30, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

LLDP Discovery by IP (librenms#10130)
* add ip polling on LLDP devices

* ipv6 support

* formatting

* codeclimate

@PipoCanaja PipoCanaja deleted the PipoCanaja:disc_lldp branch May 20, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

LLDP Discovery by IP (librenms#10130)
* add ip polling on LLDP devices

* ipv6 support

* formatting

* codeclimate

@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.