Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juniper SNMP Trap Handlers #10136

Merged
merged 14 commits into from May 1, 2019

Conversation

Projects
None yet
2 participants
@h-barnhart
Copy link
Contributor

commented Apr 23, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Adds a few SNMP Handlers for Juniper devices running Junos.

Log::event("BGP Peer $peerAddr is now in the $peerState state", $device->device_id, 'trap', 1);
}
public function formatIpv6($ipv6Raw)

This comment has been minimized.

Copy link
@murrant

murrant Apr 24, 2019

Member

We have a function that does this. IP::fromHexString()

This comment has been minimized.

Copy link
@h-barnhart

h-barnhart Apr 24, 2019

Author Contributor

I'll take a look at it. Is there a way to find to easily see what functions are available in LibreNMS, or is it something you have to pickup?

This comment has been minimized.

Copy link
@murrant

murrant Apr 28, 2019

Member

I just search the codebase usually.

h-barnhart added some commits Apr 24, 2019

@murrant

murrant approved these changes May 1, 2019

@murrant murrant merged commit 554e22d into librenms:master May 1, 2019

5 of 6 checks passed

codeclimate 13 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@h-barnhart h-barnhart deleted the h-barnhart:snmphandler-junos-1 branch May 3, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Juniper SNMP Trap Handlers (librenms#10136)
* initial commit of junos handlers

* added DOM alarm test, refactored handlers for DOM alarms

* fixed some formating issues with last commit

* Created DOM alarm handlers and unit tests

* Made tests for LSP Down handler

* Added trap tests for JnxVpnSes*, JnxVpnIf*, JnxVpnPw*

* Added BGP4 trap handlers and tests

* Fixed some variable names for codeclimate

* Simplified JnxBGPM2* handlers

* updated unit tests

@murrant murrant added the SNMP Traps label May 28, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.