Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

russian language support #10137

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
3 participants
@rkislov
Copy link
Contributor

commented Apr 23, 2019

Add ru folder in resource
DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented Apr 23, 2019

CLA assistant check
All committers have signed the CLA.

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

👍

Great start :)

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Please review the codeclimate issue - it's not a problem

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Codeclimate is an optional check. You can ignore it.

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

@rkislov as you can tell language support is ongoing. The user management was recently reworked and supports translation.

If you know anything that could help let us know.

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Tony my commit is the Russian language support for user management, I will continue translation of librenms to Russian language as quickly as will appear a new language files for translation.

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Some translations use implicit translation so they won't be explicitly in the language files.

https://laravel.com/docs/5.8/localization#using-translation-strings-as-keys

Add Translation Strings As Keys for russian language.
Translate menu.blade.php, librenms1v.blade.php
@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Some translations use implicit translation so they won't be explicitly in the language files.

https://laravel.com/docs/5.8/localization#using-translation-strings-as-keys

Ok. Translation on a way..........

@murrant
Copy link
Member

left a comment

Thanks! feel free to contribute further translations in new PRs.

@murrant murrant merged commit 125e8ec into librenms:master Apr 30, 2019

4 of 6 checks passed

Travis CI - Pull Request Build Errored
Details
codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the WebUI label Apr 30, 2019

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Ok, thanks. I’ll continue translation

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Sorry there isn't more for you to translate. A lot of the webui needs to be ported to Laravel.

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

How can I help you in porting?

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

russian language support (librenms#10137)
* russian language

* Add Translation Strings As Keys for russian language.
Translate menu.blade.php, librenms1v.blade.php
@murrant

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Old pages need to be ported to Laravel. Pick one and rewrite it using Blade and controller(s). You can check the user management or locations pages for an example.

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Ok, I'll try it

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

russian language support (librenms#10137)
* russian language

* Add Translation Strings As Keys for russian language.
Translate menu.blade.php, librenms1v.blade.php
@murrant

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@rkislov several more strings to translate here https://p.libren.ms/view/796e4972

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

Ok i’ll Translate it soon

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@rkislov several more strings to translate here https://p.libren.ms/view/796e4972
I done it
https://p.libren.ms/view/796e4972#L1

@murrant

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@rkislov do you want me to merge that for you or are you going to create a pull request?

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

I’ll make a pull request by my self to night

@rkislov

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

I'll made a pull request with updated russian language support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.