Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix services with scripts inheriting DS from previous service on detail view #10142

Merged
merged 1 commit into from Apr 28, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented Apr 24, 2019

Ensures check_ds variable is always null on each run of loop that displays services graphs. Fixes services that have script (like check_dns) but don't set check_ds on their own inheriting check_ds from previous service that ran (for example check_icmp) and displaying additional bogus graphs as result.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix services with scripts inheriting DS from previous service on deta…
…il view

Ensures check_ds variable is always null on each run of loop that displays services graphs. Fixes services that have script (like check_dns) but don't set check_dns on their own inheriting check_dns from previous service that ran (for example check_icmp) and displaying additional bogus graphs as result.

@CirnoT CirnoT force-pushed the CirnoT:patch-2 branch from f7465e0 to aa88a41 Apr 27, 2019

@CirnoT CirnoT changed the title Fix services with scripts inheriting DS from previous service on deta… Fix services with scripts inheriting DS from previous service on detail view Apr 27, 2019

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

Force-pushed to re-run Travis check.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit a7ef433 into librenms:master Apr 28, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja added the Bug 🐞 label Apr 28, 2019

@CirnoT CirnoT deleted the CirnoT:patch-2 branch Apr 28, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix services with scripts inheriting DS from previous service on deta…
…il view (librenms#10142)

Ensures check_ds variable is always null on each run of loop that displays services graphs. Fixes services that have script (like check_dns) but don't set check_dns on their own inheriting check_dns from previous service that ran (for example check_icmp) and displaying additional bogus graphs as result.

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Fix services with scripts inheriting DS from previous service on deta…
…il view (librenms#10142)

Ensures check_ds variable is always null on each run of loop that displays services graphs. Fixes services that have script (like check_dns) but don't set check_dns on their own inheriting check_dns from previous service that ran (for example check_icmp) and displaying additional bogus graphs as result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.