Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter by device and interface type on IP address search page #10143

Merged
merged 1 commit into from Apr 28, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented Apr 25, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CirnoT CirnoT force-pushed the CirnoT:patch-4 branch from b97bf16 to cb0cb1b Apr 27, 2019

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

Force-pushed to re-run Travis check.

@PipoCanaja
Copy link
Contributor

left a comment

Good catch. LGTM

@PipoCanaja PipoCanaja added the Bug 🐞 label Apr 28, 2019

@PipoCanaja PipoCanaja merged commit df2930b into librenms:master Apr 28, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:patch-4 branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.