Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store IPv4 networks as network address and fix address search page showing networks not addresses #10144

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented Apr 25, 2019

I am not sure how LibreNMS will handle it for existing addresses, possibly there needs to be some logic added to sort them out?

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

LGTM, annoying that the discovery module never removes networks...

@murrant murrant merged commit 33a51bc into librenms:master Apr 29, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Bug 🐞 label Apr 29, 2019

@CirnoT CirnoT deleted the CirnoT:patch-5 branch Apr 29, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Store IPv4 networks as network address and fix address search page sh…
…owing networks not addresses (librenms#10144)

* Store IPv4 networks as network address, not device address

* Properly display addresses, not networks on address search page

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Store IPv4 networks as network address and fix address search page sh…
…owing networks not addresses (librenms#10144)

* Store IPv4 networks as network address, not device address

* Properly display addresses, not networks on address search page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.