Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory pool for Netgear switches #10146

Merged
merged 1 commit into from Apr 27, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented Apr 25, 2019

This should close #10111 and possibly #8518 too as it seems to use same MIB based on dump of MIB table from SNMP shared by user.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CirnoT CirnoT force-pushed the CirnoT:netgear branch from 6a506bb to eb2b631 Apr 27, 2019

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

Force-pushed to have Travis re-run check.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 272fabd into librenms:master Apr 27, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:netgear branch Apr 28, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.