Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to planetos.yaml for additional models #10149

Merged
merged 1 commit into from Apr 28, 2019

Conversation

Projects
None yet
3 participants
@kmpanilla
Copy link
Contributor

commented Apr 25, 2019

Add basic support for the IGS-10080MFT and IGS-10020MT (and probably other IGS-*) models.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Updates to planetos.yaml for additional models
Add basic support for the IGS-10080MFT and IGS-10020MT (and probably other IGS-*) models.
@CLAassistant

This comment has been minimized.

Copy link

commented Apr 25, 2019

CLA assistant check
All committers have signed the CLA.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

Hello @kmpanilla
Thanx for your PR ! Could you please have a look at the tests data collection ? We need this data to run automated tests and avoid regressions.
Thanx !

@label-actions

This comment has been minimized.

Copy link

commented Apr 27, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja
Copy link
Contributor

left a comment

LGTM, tests to come in 2nd PR

@PipoCanaja PipoCanaja merged commit 35b91e9 into librenms:master Apr 28, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Updated Planetos support for additional models (librenms#10149)
Add basic support for the IGS-10080MFT and IGS-10020MT (and probably other IGS-*) models.

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Updated Planetos support for additional models (librenms#10149)
Add basic support for the IGS-10080MFT and IGS-10020MT (and probably other IGS-*) models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.