Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSU state to Netgear discovery definition #10150

Merged
merged 2 commits into from Apr 27, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented Apr 26, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@label-actions

This comment has been minimized.

Copy link

commented Apr 27, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

Hi @CirnoT
Looks good. Could you please have a look to the tests ?
Thanx

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

Added tests

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

Thanx, OK for the tests now.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit b102ced into librenms:master Apr 27, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:ng-2 branch Apr 28, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added PSU state to Netgear discovery definition (librenms#10150)
* Add PSU state to Netgear discovery definition

* Add tests for Netgear PSU

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Added PSU state to Netgear discovery definition (librenms#10150)
* Add PSU state to Netgear discovery definition

* Add tests for Netgear PSU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.