Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to planetos for ISG-* models #10152

Merged
merged 8 commits into from May 24, 2019

Conversation

Projects
None yet
4 participants
@kmpanilla
Copy link
Contributor

commented Apr 26, 2019

Gets the proper hardware model# and version of the planet IGS-* series.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Update to planetos.inc.php for ISG-* models
Gets the proper hardware model# and version of the planet IGS-* series.
@label-actions

This comment has been minimized.

Copy link

commented Apr 27, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

Same as previous PR. You don't need to put the tests in both of course. I suggest that the YAML file gets merged first and you include the test data in this PR.

@kmpanilla

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

This what we need?

planetos.json

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

This is one of the 2. We need both the snmprec and the json generated with it.

During the non regression tests, the snmprec files are all processed again and the json files are compared to the generated ones, to validate nothing is broken.

@kmpanilla

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

Here you go.
planetos.snmprec

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

Hi @kmpanilla
Could you please 'git add' those 2 files in their corresponding location (~/tests/captures for snmprec, and ~/tests/data for the json) so we have them ready for merge?

Thanx

laf and others added some commits May 1, 2019

@murrant murrant merged commit dbd0066 into librenms:master May 24, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant changed the title Update to planetos.inc.php for ISG-* models Update to planetos for ISG-* models May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.