New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to planetos for ISG-* models #10152
Conversation
Gets the proper hardware model# and version of the planet IGS-* series.
Please add test data so we can ensure your change is not broken in the future. Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units |
Same as previous PR. You don't need to put the tests in both of course. I suggest that the YAML file gets merged first and you include the test data in this PR. |
This what we need? |
This is one of the 2. We need both the snmprec and the json generated with it. During the non regression tests, the snmprec files are all processed again and the json files are compared to the generated ones, to validate nothing is broken. |
Here you go. |
Hi @kmpanilla Thanx |
Gets the proper hardware model# and version of the planet IGS-* series.
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.