Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Code-Structure.md #10156

Merged
merged 2 commits into from Apr 27, 2019

Conversation

Projects
None yet
2 participants
@pobradovic08
Copy link
Contributor

commented Apr 27, 2019

  • Added includes/html/graphs on the list
  • Changed html/includes to includes/html and reorganized the document
  • Removed part referencing old auth method using authenticate.inc.php (changed in #8702)
  • Changed terminology (from folder to directory)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

pobradovic08 added some commits Apr 27, 2019

documentation: Fix html/includes directory path
- Changed `html/includes` to `includes/html`
- Added overview of directories mentioned on the page
documentation: Cleanup Code-Structure.md
- Reorganized document
- Added `includes/html/graphs` on the list
- Changed terminology (from folder to directory)
- Removed part referencing old auth method using authenticate.inc.php (changed in #8702)
@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit b774bb6 into librenms:master Apr 27, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Updated Code-Structure.md (librenms#10156)
* documentation: Fix html/includes directory path

- Changed `html/includes` to `includes/html`
- Added overview of directories mentioned on the page

* documentation: Cleanup Code-Structure.md

- Reorganized document
- Added `includes/html/graphs` on the list
- Changed terminology (from folder to directory)
- Removed part referencing old auth method using authenticate.inc.php (changed in librenms#8702)

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Updated Code-Structure.md (librenms#10156)
* documentation: Fix html/includes directory path

- Changed `html/includes` to `includes/html`
- Added overview of directories mentioned on the page

* documentation: Cleanup Code-Structure.md

- Reorganized document
- Added `includes/html/graphs` on the list
- Changed terminology (from folder to directory)
- Removed part referencing old auth method using authenticate.inc.php (changed in librenms#8702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.