Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for APC PDU Outlet traps #10162

Merged
merged 3 commits into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented Apr 28, 2019

Let me know if you need tests for this.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@label-actions

This comment has been minimized.

Copy link

commented Apr 29, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

Tests added

@murrant
Copy link
Member

left a comment

Looks good :)

@murrant murrant merged commit ca18cf4 into librenms:master Apr 30, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:patch-8 branch Apr 30, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Support for APC PDU Outlet traps (librenms#10162)
* Support for APC PDU Outlet traps

* Add tests

* Remove unused $ipv4 from tests

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Support for APC PDU Outlet traps (librenms#10162)
* Support for APC PDU Outlet traps

* Add tests

* Remove unused $ipv4 from tests

@murrant murrant removed the Device 🖥 label May 23, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jun 29, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.