Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Avtech discovery #10163

Merged
merged 4 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Apr 29, 2019

pre-cache stored the data incorrectly, it "worked" in some cases, but not all
Fix RoomAlert 4E based on actual data (MIB might be outdated)

fixes #10145

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix Avtech discovery
pre-cache stored the data incorrectly

@murrant murrant added the Device 🖥 label Apr 29, 2019

murrant added some commits Apr 29, 2019

Fix RA-4E external sensors
sen1 had incorrect oids (duplicate of sen2)
Description oid from data doesn't match the mib, perhaps outdated MIB?
@laf

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Does this maintain backwards compatibility with older devices? the issue seems to suggest this is only one model having issues.

@murrant

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

Yes. And the 4E was written only looking at the MIB. I have several other devices and it is causing no issues with them. Previous discovery was doing a substring on the value returned, so it kinda worked, and the initial value would be wrong.

@laf

laf approved these changes May 2, 2019

Copy link
Member

left a comment

LGTM

@laf laf changed the title Fix Avtech discovery Fixed Avtech discovery May 2, 2019

@laf laf merged commit 3e7970b into librenms:master May 2, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:avtech-discovery branch May 2, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Fixed Avtech discovery (librenms#10163)
* Fix Avtech discovery
pre-cache stored the data incorrectly

* Fix RA-4E external sensors
sen1 had incorrect oids (duplicate of sen2)
Description oid from data doesn't match the mib, perhaps outdated MIB?

* add test data

* Updated 4E MIB

@lock lock bot locked as resolved and limited conversation to collaborators Jul 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.