Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial number and more robust OS version for Netgear switches #10164

Merged
merged 3 commits into from Apr 29, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented Apr 29, 2019

Some Netgear switches don't report their software version in description, instead they report it in entPhysicalSoftwareRev.

This PR also adds support for fetching serial number from entPhysicalSerialNum.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja
Copy link
Contributor

left a comment

Too fast for approval :) Let's do that again.

@PipoCanaja
Copy link
Contributor

left a comment

Looks better now :)

@PipoCanaja PipoCanaja merged commit fb32536 into librenms:master Apr 29, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:patch-3 branch Apr 30, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Serial number and more robust OS version for Netgear switches (libren…
…ms#10164)

* Serial number and more robust OS version for Netgear switches

* Update netgear.inc.php

* Update netgear.inc.php

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Serial number and more robust OS version for Netgear switches (libren…
…ms#10164)

* Serial number and more robust OS version for Netgear switches

* Update netgear.inc.php

* Update netgear.inc.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.