Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified adva port label to use ifname #10165

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
3 participants
@h-barnhart
Copy link
Contributor

commented Apr 29, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

This will make the GUI display the ifName (ie. network port-1-1-1-3) versus the default of ifDescr which is 'ETHERNET ACCESS (or NETWORK)'. This should work on FSP 150 family devices.

@h-barnhart

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

For some reason on initial pull request git spawned two TravisCI build and the second one never completed. I did a rebase to restart checks and I'm only seeing one TravisCI check this time.

@PipoCanaja
Copy link
Contributor

left a comment

Tested and works well, LGTM

@PipoCanaja PipoCanaja merged commit 36134fd into librenms:master Apr 30, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Thanx for this !

@h-barnhart h-barnhart deleted the h-barnhart:adva-ifname branch May 3, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

@murrant murrant added the Device 🖥 label May 28, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.