Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for APC PDU outlet state sensors #10166

Merged
merged 2 commits into from May 1, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented Apr 29, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CirnoT CirnoT changed the title Separate APC MasterSwitch to its own OS and add support for outlet state sensors WIP: Separate APC MasterSwitch to its own OS and add support for outlet state sensors Apr 29, 2019

@CirnoT CirnoT force-pushed the CirnoT:apc-ms branch from fd2e3e8 to 04bc457 Apr 29, 2019

@CirnoT CirnoT changed the title WIP: Separate APC MasterSwitch to its own OS and add support for outlet state sensors Add support for APC PDU outlet state sensors Apr 29, 2019

@laf

laf approved these changes May 1, 2019

Copy link
Member

left a comment

Brilliant, thanks for contributing :)

@laf laf changed the title Add support for APC PDU outlet state sensors Added support for APC PDU outlet state sensors May 1, 2019

@laf laf merged commit 9d5e780 into librenms:master May 1, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Device 🖥 label May 1, 2019

@CirnoT CirnoT deleted the CirnoT:apc-ms branch May 1, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Added support for APC PDU outlet state sensors (librenms#10166)
* Add support for APC PDU outlet state sensors

* Update tests

@lock lock bot locked as resolved and limited conversation to collaborators Jun 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.