Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNMP Trap Handlers for Ruckus Wireless #10175

Merged
merged 9 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@h-barnhart
Copy link
Contributor

commented May 1, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

A few trap handlers and associated tests for Ruckus Wireless devices. Tested with R720 access points and SmartZone running 3.6.2 firmware.

@h-barnhart

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Noticed PR 10177 adds SNMP Cold Start so I'm going to remove it from this request as it is out of scope.

h-barnhart added some commits May 2, 2019

@h-barnhart

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Inspection got stuck, rebased to start recheck process.

'RUCKUS-EVENT-MIB::ruckusEventDiassocTrap' => \LibreNMS\Snmptrap\Handlers\RuckusDiassocTrap::class,
'RUCKUS-EVENT-MIB::ruckusEventSetErrorTrap' => \LibreNMS\Snmptrap\Handlers\RuckusSetError::class,
'RUCKUS-SZ-EVENT-MIB::ruckusSZAPMiscEventTrap' => \LibreNMS\Snmptrap\Handlers\RuckusSzApMiscEvent::class,
'RUCKUS-SZ-EVENT-MIB::ruckusSZAPFirmwareUpdatedTrap' => \LibreNMS\Snmptrap\Handlers\RuckusSzApFirmware::class,

This comment has been minimized.

Copy link
@murrant

murrant May 13, 2019

Member

Scrutinizer is complaining about some of these classes not existing, did you forget to add them?

@h-barnhart

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

I must have just copied the snmptraps.php from my test build and forgot I have some traps I have identified for handling but haven't had a chance to collect samples for yet.

@murrant murrant merged commit b7053ad into librenms:master May 13, 2019

5 of 6 checks passed

codeclimate 6 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@h-barnhart h-barnhart deleted the h-barnhart:snmphandler-ruckus-1 branch May 14, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

SNMP Trap Handlers for Ruckus Wireless (librenms#10175)
* pushing handlers and AP event tests

* adding tests for SZ events

* Fixed state handler, added state handler tests

* Style checks and cleanup

* fixed a style issue in RuckusSzClusterInMaintenance.php

* removed SNMP Cold Start trap

* fixed snmptraps.php to remove unhandled traps

@murrant murrant added the SNMP Traps label May 28, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.