Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Raspberry Pi frequency, voltage and state sensors discovery #10176

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented May 1, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@label-actions

This comment has been minimized.

Copy link

commented May 1, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Tests added

@PipoCanaja
Copy link
Contributor

left a comment

Looks good ! Thanx

@PipoCanaja PipoCanaja merged commit 308145d into librenms:master May 2, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:rpi branch May 12, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Fixed Raspberry Pi sensors discovery (librenms#10176)
* Fixed Raspberry Pi frequency, voltage and state sensors discovery
* Added tests

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.