Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional generic SNMP trap handlers #10177

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@CirnoT
Copy link
Contributor

commented May 2, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Show resolved Hide resolved config/snmptraps.php Outdated
@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Sorted it as requested. In the process also noticed dead entry to AdvaConfigChange on ENTITY-MIB::entConfigChange which has no corresponding file. Didn't notice before as I wrote the code before merging with changes that added Adva stuff.

@laf laf added the Feature label May 2, 2019

@laf

laf approved these changes May 2, 2019

Copy link
Member

left a comment

LGTM

@laf laf changed the title Add more generic SNMP trap handlers Added additional generic SNMP trap handlers May 2, 2019

@laf laf merged commit eb8600e into librenms:master May 2, 2019

5 of 6 checks passed

codeclimate 4 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Another good reason to sort them ;)

@CirnoT CirnoT deleted the CirnoT:patch-9 branch May 2, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Added additional generic SNMP trap handlers (librenms#10177)
* Add more generic SNMP trap handlers

* Sort snmptraps config alphabetically

@murrant murrant added the SNMP Traps label May 28, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.