Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traditional Chinese language support #10178

Merged
merged 14 commits into from Jun 21, 2019

Conversation

Projects
None yet
3 participants
@jasoncheng7115
Copy link
Contributor

commented May 2, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

jasoncheng7115 added some commits May 2, 2019

@laf

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@murrant Saw this one merged the other day: https://github.com/librenms/librenms/pull/10137/files does this also need the additional php files updating like that PR?

@jasoncheng7115

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@murrant Saw this one merged the other day: https://github.com/librenms/librenms/pull/10137/files does this also need the additional php files updating like that PR?

By the way,
When I try to change the locale Settings in app.php, the system does use the zh-TW. json language string, but only a fraction and the menubar doesn't change.

2019-05-03 09_22_59-mRemoteNG - confCons xml - mon1 - 172 16 1 180
2019-05-03 09_23_56-LibreNMS

@murrant

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Very few portions of the system support translation. There is a PR that I hope will be merged soon that will add support for the whole main menu. (you can preview this menu by visiting /locations)
#10173

@murrant

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Any missed translations for things that are done in Laravel Blade can be fixed pretty easily by wrapping them in @lang() or __(). Send a separate PR for those please.

@murrant

This comment has been minimized.

Copy link
Member

commented May 6, 2019

This also reminds, me, we should create a .env setting for locale.

@murrant

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@jasoncheng7115 you have not translated all those strings (such as "Ignored"). We don't have any guide or assistance on how to find the strings that need translation at this time, language support is still in its infancy in LibreNMS. You can check the Russian translation files for some things that need to be added (those are incomplete too).

@jasoncheng7115

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@jasoncheng7115 you have not translated all those strings (such as "Ignored"). We don't have any guide or assistance on how to find the strings that need translation at this time, language support is still in its infancy in LibreNMS. You can check the Russian translation files for some things that need to be added (those are incomplete too).

Yes, I did translate zh-TW.json from ru.json. So the missing part will be the same as ru.json.
Suggest a file I must refer to?

@murrant

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@jasoncheng7115 You could use this to find all the translatable strings: https://github.com/kkomelin/laravel-translatable-string-exporter

I might add it to upstream as a dev dependency, but not atm. You can add it to your local install and use it.

@murrant

This comment has been minimized.

Copy link
Member

commented May 13, 2019

A current list of strings that need translation: https://p.libren.ms/view/796e4972 (New ones are added all the time)

@jasoncheng7115

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

A current list of strings that need translation: https://p.libren.ms/view/796e4972 (New ones are added all the time)

No problem. Let me translate traditional Chinese.
Is the file name the same as "resources/lang/zh-tw.json "?

@murrant

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Yes

@murrant

This comment has been minimized.

Copy link
Member

commented May 29, 2019

I've added a new file to specify the language name in the select screen #10272

@jasoncheng7115

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

I've added a new file to specify the language name in the select screen #10272

I have updated this translation file.

jasoncheng7115 added some commits May 30, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented May 30, 2019

You are still missing the other translation files that should be in the zh-TW directory, see the ru folder for starters.

jasoncheng7115 added some commits Jun 1, 2019

@jasoncheng7115

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

You are still missing the other translation files that should be in the zh-TW directory, see the ru folder for starters.

Thanks for the tip. Relevant files have been added.

jasoncheng7115 added some commits Jun 4, 2019

@murrant murrant added the Translation label Jun 7, 2019

@murrant
Copy link
Member

left a comment

Merging pending translations.
Send new PR to update/expand.

@murrant murrant merged commit 1d2adec into librenms:master Jun 21, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.