Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better services graphing support #10185

Merged
merged 3 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented May 3, 2019

  • This moves services graph code from device/ to service/ and removes unused code (service/availability.inc.php). This has no real changes to end-user except ensuring that when viewing graph, proper title is shown:

After:
chrome_2019-05-03_17-35-12
Before:
chrome_2019-05-03_17-35-49

  • Second commit adds proper support for services in dashboard graph widget. Previously it was piggy-backing on generic device graph, which made it impossible to select specific service for device (first service would be always used). This adds same level of support for services as present with Munin Plugins, where you can select service to be graphed.

chrome_2019-05-03_17-38-27

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CirnoT CirnoT changed the title WIP: Better services support Better services graphing support May 3, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Looks good but. I think it could cause some issues if people are linking to existing graphs called device_service. Either find a way to redirect that or we can just send a user notification probably.

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

I think sending notification would be preferred over adding additional logic for redirecting (which may cause issues later on if we decide to have service graph under device for something else than Nagios services).

@murrant

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Could you create a notification on https://github.com/librenms/librenms.github.io ?

CirnoT added a commit to CirnoT/librenms.github.io that referenced this pull request May 10, 2019

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@murrant murrant merged commit ef90da2 into librenms:master May 13, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

murrant added a commit to librenms/librenms.github.io that referenced this pull request May 13, 2019

Better services graphing support (#116)
* Better services graphing support

Related to librenms/librenms#10185

* Update notifications.rss

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Better services graphing support (librenms#10185)
* Move services graph code from device to service and remove unused code

* Add proper support for services to dashboard graph weidget

* Fix phpdoc in ServiceController still pointing to MuninPluginController

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.