Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast alert ID to string for PD API #10186

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
4 participants
@supertylerc
Copy link
Contributor

commented May 3, 2019

This is a simple one. The PagerDuty API expects the Alert ID to be a string, and currently it is not. It seems that it may have been a change on PagerDuty's end to start enforcing the type as this used to work, but it suddenly broke one day and I don't think it was because of LibreNMS.

PagerDuty docs reference: https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented May 3, 2019

CLA assistant check
All committers have signed the CLA.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 8919758 into librenms:master May 3, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Hi @supertylerc
Thanx for the fix !

@supertylerc supertylerc deleted the supertylerc:tyler/fix-pd-dedup-key branch May 5, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.