Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed broken POE graphing code #10188

Merged
merged 3 commits into from May 29, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented May 4, 2019

Hello

Currently, there is no way to poll POE values and graph them with standard MIB. The only standard info we can get is "do we have POE available and active" but this information is not used in LibreNMS so far.
The removed code did use some specific Cisco MIBS for the values, which obviously do not return any value for non Cisco devices.
This PR is removing the code to avoid unnecessary polling of useless values. And also, currently, unnecessary creation of empty RRD (waste of space).

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

PipoCanaja added some commits May 4, 2019

//This is the legacy code, to be tested against devices. This code looks terribly broken. There is
//most probably no device that can show anything out of this ...
if ($this_port['dot3StatsIndex'] && $port['ifType'] == 'ethernetCsmacd') {

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja May 4, 2019

Author Contributor

This condition is really broken. A lot of devices do have dot3StatsIndex set and will then create a completely empty RRD ...

@PipoCanaja PipoCanaja self-assigned this May 4, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented May 6, 2019

I'll take a look. I think some devices support PoE info with a state sensor (off, 24v, 48v, etc)

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Then we would probably need different RRDs for them, cause the current structure is very bound to the Cisco implementation.

@murrant murrant added this to the 1.53 milestone May 23, 2019

@murrant murrant merged commit ccb6e2e into librenms:master May 29, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 2 fixed issues
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.