Removed broken POE graphing code #10188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PipoCanaja
commented
May 4, 2019
| //This is the legacy code, to be tested against devices. This code looks terribly broken. There is | ||
| //most probably no device that can show anything out of this ... | ||
|
|
||
| if ($this_port['dot3StatsIndex'] && $port['ifType'] == 'ethernetCsmacd') { |
There was a problem hiding this comment.
This condition is really broken. A lot of devices do have dot3StatsIndex set and will then create a completely empty RRD ...
|
I'll take a look. I think some devices support PoE info with a state sensor (off, 24v, 48v, etc) |
|
Then we would probably need different RRDs for them, cause the current structure is very bound to the Cisco implementation. |
murrant
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Currently, there is no way to poll POE values and graph them with standard MIB. The only standard info we can get is "do we have POE available and active" but this information is not used in LibreNMS so far.
The removed code did use some specific Cisco MIBS for the values, which obviously do not return any value for non Cisco devices.
This PR is removing the code to avoid unnecessary polling of useless values. And also, currently, unnecessary creation of empty RRD (waste of space).
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.