Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix broken links and anchors #10194

Merged
merged 4 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@pobradovic08
Copy link
Contributor

commented May 6, 2019

  1. Fixed broken link in Transports.md that points to nonexistant:
    https://docs.librenms.org/Alerting/Transports/Templates#syntax
    instead of:
    https://docs.librenms.org/Alerting/Templates/#syntax

  2. Changed Alerting link in Configuration.md to point to Alerting Intro instead of Alerting Rules.

  3. Fixed broken anchor in Fast-Ping-Check.md

  4. Took the chance to add myself to AUTHORS.md

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

pobradovic08 added some commits May 6, 2019

@pobradovic08 pobradovic08 changed the title Documentation Documentation: Fix broken links and anchors May 6, 2019

@murrant

murrant approved these changes May 7, 2019

Copy link
Member

left a comment

These all look good to me. Thanks for the fixes!

@murrant murrant merged commit 2d24609 into librenms:master May 7, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Documentation: Fix broken links and anchors (librenms#10194)
* documentation: Fix broken Templates.md link

* Update AUTHORS.md

* docs: Fix broken anchor in Fast-Ping-Check.md

* docs: Changed Alerting link in Configuration.md

@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.