Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move container to page in blade tempates #10195

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented May 7, 2019

That way the page can decide container-fluid or container
Remove some unused blade templates as we have our own now

Maybe we could just nest a container inside a container fluid, but I feel like this is slightly better.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Move container to page in blade tempates
That way the page can decide container-fluid or container
Remove some unused blade templates as we have our own now

@murrant murrant added the WebUI label May 7, 2019

@CirnoT

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Looks ok as far as I tested however there is an issue when this PR is combined with #10173

chrome_2019-05-07_14-52-15

For reference, this is how it looks with either of them or without any of them:
chrome_2019-05-07_14-50-33

@murrant

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@CirnoT yeah, I plan to rebase that PR on this one.

@murrant murrant merged commit 143cf4c into librenms:master May 10, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:container-outside branch May 10, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Move container to page in blade tempates (librenms#10195)
That way the page can decide container-fluid or container
Remove some unused blade templates as we have our own now

@lock lock bot locked as resolved and limited conversation to collaborators Jul 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.