Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty IPv4 addresses in discovery on buggy devices #10198

Merged
merged 3 commits into from May 9, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented May 8, 2019

Reported on Discord:

Error in ipv4-addresses module. /0 is not a valid ipv4 address
#0 /opt/librenms/includes/discovery/ipv4-addresses.inc.php(20): LibreNMS\Util\IPv4->__construct('/0')
#1 /opt/librenms/includes/discovery/functions.inc.php(179): include('/opt/librenms/i...')
#2 /opt/librenms/discovery.php(120): discover_device(Array, false)
#3 {main}

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

CirnoT added some commits May 8, 2019

@murrant

murrant approved these changes May 9, 2019

Copy link
Member

left a comment

Great

@murrant murrant added the Bug 🐞 label May 9, 2019

@murrant murrant merged commit b4f0380 into librenms:master May 9, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:patch-1 branch May 12, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Ignore empty IPv4 addresses in discovery on buggy devices (librenms#1…
…0198)

* Ignore empty IPv4 addresses in discovery on buggy devices

* Styling fixes for codeclimate

* Use try/catch block instead

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.