Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state sensors on device health page showing always as OK (green) #10200

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented May 8, 2019

This is continuation of #10171 - same issue but in different place this time.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Bug 🐞 label May 9, 2019

@murrant

murrant approved these changes May 9, 2019

@murrant murrant merged commit 4e43594 into librenms:master May 9, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 2 fixed issues
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:state_health branch May 12, 2019

@murrant murrant added the WebUI label May 13, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.