Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PoE state sensor on Mikrotik devices #10201

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
2 participants
@CirnoT
Copy link
Contributor

commented May 8, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CirnoT

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

There's an issue with tests here that I am not sure how to solve properly.
Solved now. For future reference, routeros.snmprec seems to be full SNMP dump while routeros.json is obviously generated based on current sensors. When adding new sensors to routeros.yaml always remember to regenerate routeros.json as routeros.snmprec may already have SNMP OID for that sensor.

@CirnoT CirnoT force-pushed the CirnoT:mikrotik_state_poe branch from 5926983 to 1cec25e May 9, 2019

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit f036b1d into librenms:master May 9, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@CirnoT CirnoT deleted the CirnoT:mikrotik_state_poe branch May 12, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.