Added aggregate config option to Billing 95th percentile calculations #10202
This is very small change but it is required for our environment and I'm hoping to be able to upgrade without continually re-merging these files.
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
I'm sorry, I thought I responded to that. Yes, it probably should be. I'd guess most environments are all or nothing, but for inclusion in upstream per-bill makes more sense. The 95th percentile direction column could probably be used for that, if its set to "agg" the poller combines the values, otherwise is uses the existing behavior of setting the direction to in/out and using the max value for the billing cycle. I'll take a look at that a little more closely later this week to see if there are any pitfalls there, but that saves adding another DB column that probably isn't necessary.
May 28, 2019
I've found a problem in your code, causing Traffic Bill graphs to fail to load, with the following error (and stack trace):
It would appear that "function getRates($bill_id, $datefrom, $dateto)" was changed to "function getRates($bill_id, $datefrom, $dateto, $dir_95th)", without updating "$rates = getRates($vars['id'], $datefrom, $dateto);" at https://github.com/librenms/librenms/blame/master/includes/html/graphs/bill/bits.inc.php#L6.
Can someone possibly fix this? Thanks!
Thank you for the heads up, I'll get this fixed ASAP.