Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User configurable locale (language) #10204

Merged
merged 13 commits into from May 23, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented May 10, 2019

Ports the user preferences page to Laravel

Some other goodies such as setting default locale in .env and nicer demo user denied pages.

image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant force-pushed the murrant:locale-support branch from 740d744 to 8607db3 May 10, 2019

@murrant murrant added this to the 1.52 milestone May 19, 2019

@murrant murrant merged commit 90a67c2 into librenms:master May 23, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:locale-support branch May 23, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.